Re: [PATCH] refs: Fix valgrind suppression file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David Turner <dturner@xxxxxxxxxxxxxxxx> writes:

> Add all of the ways in which check_refname_format violates valgrind's
> expectations to the valgrind suppression file; remove an assumption about
> the call chain of check_refname_format from same.
>
> Signed-off-by: David Turner <dturner@xxxxxxxxxxx>
> ---
>  t/valgrind/default.supp | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)

I'll queue, but it makes me feel more and more disgusted with that
SSE patch, to be honest.

>
> diff --git a/t/valgrind/default.supp b/t/valgrind/default.supp
> index 332ab1a..9d51c92 100644
> --- a/t/valgrind/default.supp
> +++ b/t/valgrind/default.supp
> @@ -50,10 +50,17 @@
>  	fun:copy_ref
>  }
>  {
> -	ignore-sse-check_refname_format
> +	ignore-sse-check_refname_format-addr
>  	Memcheck:Addr8
>  	fun:check_refname_format
> -	fun:cmd_check_ref_format
> -	fun:handle_builtin
> -	fun:main
> +}
> +{
> +	ignore-sse-check_refname_format-cond
> +	Memcheck:Cond
> +	fun:check_refname_format
> +}
> +{
> +	ignore-sse-check_refname_format-value
> +	Memcheck:Value8
> +	fun:check_refname_format
>  }
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]