Re: [PATCH v5 2/2] test-config: Add tests for the config_set API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes:

> A couple of quick nits.
>
> Tanay Abhra wrote:
>> +test_expect_success 'clear default config' '
>> +       rm -f .git/config
>> +'
>
> Unnecessary; a fresh temporary directory is created for each test run.

Hmm, fresh, but not empty.

Anyway, the next test does a cat > on this file, so it will erase its
content, so the "rm -f" is actually not needed.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]