Re: Is column.ui.* configuration a bit too strong?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 24, 2014 at 2:03 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Since its inception at 7e29b825 (Add column layout skeleton and
> git-column, 2012-04-21), it seems that git_column_config() asked for
> a specific $command did not give "column.$command.*" any precedence
> over the fallback value defined for "column.ui.*".  If you happen to
> have column.ui.* earlier than the corresponding column.$command.* in
> your configuration, then the values come from column.ui.* may be
> overwritten, but the code does not seem to enforce "if there is a
> setting for a specific command, honor that, otherwise fall back to
> the generic 'ui' setting".
>
> Am I misreading the code?

Hmm.. probably not. The way I read it, the git_column_config() relies
on the order that git_config() calls it, which should be "undefined
order" from git_column_config point of view.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]