On Thu, Jun 19, 2014 at 10:30:36PM -0400, Eric Sunshine wrote: > > diff --git a/git-compat-util.h b/git-compat-util.h > > index 556c839..1187e1a 100644 > > --- a/git-compat-util.h > > +++ b/git-compat-util.h > > @@ -350,8 +350,9 @@ extern int starts_with(const char *str, const char *prefix); > > extern int ends_with(const char *str, const char *suffix); > > > > /* > > - * If "str" begins with "prefix", return 1. If out is non-NULL, > > - * it it set to str + strlen(prefix) (i.e., the prefix is skipped). > > + * If the string "str" begins with the string found in "prefix", return 1. > > + * The "out" parameter is set to "str + strlen(prefix)" (i.e., to the point in > > + * the string right after the prefix). > > * > > * Otherwise, returns 0 and out is left untouched. > > For consistency with the preceding paragraph: > > Otherwise, return 0 and leave "out" untouched. Heh, I even noticed the verb tense mismatch but thought "nah, nobody will care". I see I was wrong. :) Here is the full squashable patch against v1, in case Junio picks it up from here (or it will be in my re-roll if necessary). diff --git a/git-compat-util.h b/git-compat-util.h index 556c839..d29e1df 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -350,10 +350,11 @@ extern int starts_with(const char *str, const char *prefix); extern int ends_with(const char *str, const char *suffix); /* - * If "str" begins with "prefix", return 1. If out is non-NULL, - * it it set to str + strlen(prefix) (i.e., the prefix is skipped). + * If the string "str" begins with the string found in "prefix", return 1. + * The "out" parameter is set to "str + strlen(prefix)" (i.e., to the point in + * the string right after the prefix). * - * Otherwise, returns 0 and out is left untouched. + * Otherwise, return 0 and leave "out" untouched. * * Examples: * -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html