Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
> +static struct object_hash file_trees = { 0, 0, NULL };
> +static struct object_array file_commits = { 0, 0, NULL };
These don't look good for two reasons: (1) you could leave BSS
to do the 0 initialization; (2) you need to change this if you
need to change the shape of "struct object_hash" later.
> +#define CONTAINS_FILE (1u<<10)
I am partly at fault, but I think we should have a consolidated
bit assignment policy in place before introducing new users of
object flags. Some older code says in their comments that
revision.h reserves lower 8 bits while others say 16. I offhand
know who is correct X-<.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html