On Mon, Jun 16, 2014 at 11:29:39AM -0700, Junio C Hamano wrote: > nori <semtlenori@xxxxxxxxx> writes: > > > extract_content_type() could not extract a charset parameter if the > > parameter is not the first one and there is a whitespace and a following > > semicolon just before the parameter. For example: > > > > text/plain; format=fixed ;charset=utf-8 > > > > Signed-off-by: Yi EungJun <eungjun.yi@xxxxxxxxxxxxx> > > --- > > Peff, doesn't this look somehow familiar? Perhaps with e3131626 > (http: optionally extract charset parameter from content-type, > 2014-05-22), this patch is unnecessary? No, I think this is built on top of e3131626 to catcha case I mised. It looks OK at first glance, but I'd really like to add better test coverage for this parsing. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html