René Scharfe wrote: > - if (incomplete) > - *lineno++ = len; > + *lineno = len; > > - sb->num_lines = num + incomplete; > + sb->num_lines = num; This will always treat whatever comes after the last newline as an incomplete line, even if it has zero length. Is that safe? (Not a rhetorical question --- I haven't looked carefully at the caller.) Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html