Heiko Voigt <hvoigt@xxxxxxxxxx> writes:
> ...
> +static int is_cache_init = 0;
Please don't initialise variables in the .bss to zero by hand.
> + ...
> + warning("%s:.gitmodules, multiple configurations found for "
> + "submodule.%s.%s. Skipping second one!",
> + commit_string, name, option);
> +}
> + ...
> + if (strcmp(value, "untracked") && strcmp(value, "dirty") &&
> + strcmp(value, "all") && strcmp(value, "none")) {
> + warning("Invalid parameter \"%s\" for config option "
> + "\"submodule.%s.ignore\"", value, var);
> + goto release_return;
> + }
These two look inconsistent in different ways. I think we typically
quote the names like so:
warning("I have trouble with variable '%s' somehow", var);
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html