frrrwww@xxxxxxxxx wrote on Wed, 11 Jun 2014 14:06 +0100:
> On Tue, Jun 10, 2014 at 06:39:58PM -0400, Pete Wyckoff wrote:
> > frrrwww@xxxxxxxxx wrote on Tue, 10 Jun 2014 13:14 +0100:
> > > b4073bb387ef303c9ac3c044f46d6a8ae6e190f0 broke git p4 submit, here
> > > is a proper fix, including proper handling for windows end of lines.
> >
> > I guess we don't have test coverage for these cases? Is this
> > something that should get put into a maintenance release, quickly?
>
> We have test cases for that, however we need to create a link to git-p4.py
> named git-p4 in order for them to work. I did not run the first patch through
> the tests (see my previous email) because of that. Sorry about that.
The secret is to "build" the code before running tests, just like
when working on .c files. I tend to do something like:
make git-p4 && (cd t ; make T="$(echo t98*)") ; pkill p4d
Thanks for catching the problem quickly and fixing it.
-- Pete
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html