On Tue, Jun 10, 2014 at 10:18 AM, Pasha Bolokhov
<pasha.bolokhov@xxxxxxxxx> wrote:
>> On Thu, Jun 5, 2014 at 3:15 AM, Pasha Bolokhov <pasha.bolokhov@xxxxxxxxx> wrote:
>>> + /* only add it if GIT_DIR does not end with '.git' or '/.git' */
>>> + if (len < 4 || strcmp(n_git + len - 4, ".git") ||
>>> + (len > 4 && n_git[len - 5] != '/')) {
>>
>> Hmm.. should we exclude "foobar.git" as well?
>
> Why wouldn't we? Everything that has basename ".git" is hard-wired
> to be excluded, but everything else, including "foobar.git" should be
> added to the excludes manually... How is it better than just "foobar"?
Yes everything except ".git" should be excluded. And you do exactly
that. I misread the code (probably better to write "if (!(<basename is
".git>))", maybe)
--
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html