Here's a re-roll of the commit-slab series. It fixes the issues pointed out by Eric and Christian (thanks, both). It adds two new patches at the beginning to clean up the dangerous strbufs that we discussed elsewhere. And as a result, silences the warning from the old 12/15. I even compiled with a working copy of gcc to confirm. :) [01/17]: commit_tree: take a pointer/len pair rather than a const strbuf [02/17]: replace dangerous uses of strbuf_attach [03/17]: alloc: include any-object allocations in alloc_report [04/17]: commit: push commit_index update into alloc_commit_node [05/17]: do not create "struct commit" with xcalloc [06/17]: logmsg_reencode: return const buffer [07/17]: sequencer: use logmsg_reencode in get_message [08/17]: provide a helper to free commit buffer [09/17]: provide a helper to set the commit buffer [10/17]: provide helpers to access the commit buffer [11/17]: use get_cached_commit_buffer where appropriate [12/17]: use get_commit_buffer to avoid duplicate code [13/17]: convert logmsg_reencode to get_commit_buffer [14/17]: use get_commit_buffer everywhere [15/17]: commit-slab: provide a static initializer [16/17]: commit: convert commit->buffer to a slab [17/17]: commit: record buffer length in cache -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html