On Wed, Jun 4, 2014 at 3:55 AM, Pasha Bolokhov <pasha.bolokhov@xxxxxxxxx> wrote: >> The case when $GIT_DIR points to a _file_ seems uncovered. >> setup_git_directory() will transform the file to the directory >> internally and we never know the .git file's path (so we can't exclude >> it). So people could accidentally add the .git file in, then remove it >> from from work tree and suddenly the work tree becomes repo-less. It's >> not as bad as .git _directory_ because we don't lose valuable data. I >> don't know if you want to cover this too. > > That's right, there is no way of knowing what the original .git file > was. I guess the only way to work around this problem is to modify > "read_gitfile()" so it saves the name of the original file. Then we > can add both that .git-file and GIT_DIR to the exclude list. Not a big > problem with me, but need to see what you guys think My view is this non-standard $(basename $GIT_DIR) is a corner case. Unless people who care about it (e.g. you) do something that affects the common ".git" case, or really mess up the code, I don't think it's a problem if you decide to ignore some smaller cases. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html