On Fri, May 30, 2014 at 01:44:32PM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > Subject: [PATCH] reuse commit->buffer when parsing signatures > > ... > > Signed-off-by: Jeff King <peff@xxxxxxxx> > > Hmph, unfortunately this seems to break t7510. Urgh, sorry for not testing more thoroughly. I imagine it is because of the strlen(commit->buffer) I introduced. Unfortunately I do not know if we have an easy way to know the length of commit->buffer, short of hitting sha1_object_info (which is somewhat expensive to do for every commit). I wonder if it would be sane to remove or quote NULs when attaching the buffer to commit->buffer. That would _break_ signatures, but that is a good thing. I do not think there is a reason to have NULs in your commit message unless you are doing something malicious (or using utf16, but that already is horribly broken). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html