On Fri, May 23, 2014 at 04:22:22PM -0500, Caleb Thompson wrote: > This patch allows people to set `commit.verbose` to implicitly send `--verbose` ... > > +cat >check-for-no-diff <<EOF > +#!$SHELL_PATH > +exec grep -v '^diff --git' "\$1" > +EOF > +chmod +x check-for-no-diff > + For new tests, commands like this should be placed inside a test_expect_success structure. However, I can see why you did it this way since the code just above it does it this way. Perhaps others will have some recommendations. Also, <<\-EOF is used instead of <<EOF to remove the tabs. test_expect_success 'commit verbose setup' ' cat >check-for-no-diff <<\-EOF && #!SHELL_PATH exec grep -v '^diff --git' "\$1" EOF chmod +x check-for-no-diff ' > > +test_expect_success 'commit shows verbose diff with set commit.verbose' ' > + echo morecontent >file && > + git add file && > + git config commit.verbose true && > + check_message message > +' 'test_config' should be used to set config variables since it also takes care of un-setting them when the test is complete. test_expect_success 'commit shows verbose diff with set commit.verbose' ' echo morecontent >file && git add file && test_config commit.verbose true && check_message message ' -- Jeremiah Mahler jmmahler@xxxxxxxxx http://github.com/jmahler -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html