Jeff King <peff@xxxxxxxx> writes: >> > Yes, and that would be fine with me (I actually wrote strbuf_tolower for >> > my own use, and _then_ realized that we already had such a thing that >> > could be replaced). >> ... > ... I think > the bigger question is: is this refactor worth doing, since there is > only one caller? If you wrote it for your own use and then realized that it is applicable to this codepath, wouldn't that say that there are multiple potential callers that would benefit from having it? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html