Ronnie Sahlberg wrote: > +++ b/refs.c [...] > @@ -3518,14 +3499,16 @@ int ref_transaction_commit(struct ref_transaction *transaction, > struct ref_update *update = updates[i]; > > if (!is_null_sha1(update->new_sha1)) { > - ret = update_ref_write(msg, > - update->refname, > - update->new_sha1, > - update->lock, err, > - UPDATE_REFS_QUIET_ON_ERR); > + ret = write_ref_sha1(update->lock, update->new_sha1, > + msg); This changes the return value on error from 1 to -1. That seems like a good change. It's probably worth mentioning in the commit message. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html