On 20/05/14 22:40, Jonathan Nieder wrote: > Ramsay Jones wrote: > >> --- a/t/t0000-basic.sh >> +++ b/t/t0000-basic.sh >> @@ -296,8 +296,9 @@ test_expect_success 'test --verbose-only' ' >> ' >> >> test_expect_success 'GIT_SKIP_TESTS' " >> - GIT_SKIP_TESTS='git.2' \ >> - run_sub_test_lib_test git-skip-tests-basic \ >> + GIT_SKIP_TESTS='git.2' && export GIT_SKIP_TESTS && >> + test_when_finished sane_unset GIT_SKIP_TESTS && > > Oof. Good catch. > > What should happen if I have set GIT_SKIP_TESTS explicitly to run > only some of the tests in t0000-basic? A quick test (with the above patch applied) shows that it works as I would expect: $ GIT_SKIP_TESTS=t0000.1[2-6] ./t0000-basic.sh ... ok 11 - test --verbose ok 12 # skip test --verbose-only (GIT_SKIP_TESTS) ok 13 # skip GIT_SKIP_TESTS (GIT_SKIP_TESTS) ok 14 # skip GIT_SKIP_TESTS several tests (GIT_SKIP_TESTS) ok 15 # skip GIT_SKIP_TESTS sh pattern (GIT_SKIP_TESTS) ok 16 # skip --run basic (GIT_SKIP_TESTS) ok 17 - --run with a range ... ok 77 - very long name in the index handled sanely # passed all 77 test(s) 1..77 $ ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html