Hi, Elia Pinto wrote: > These patch series convert test -a/-o to && and ||. Should this come with a new check in t/check-non-portable-shell.pl so we don't regress in the future? > Elia Pinto (19): [...] > check_bindir | 2 +- > contrib/examples/git-clone.sh | 2 +- > contrib/examples/git-commit.sh | 4 ++-- > contrib/examples/git-merge.sh | 4 ++-- > contrib/examples/git-repack.sh | 4 ++-- > contrib/examples/git-resolve.sh | 2 +- > git-bisect.sh | 2 +- > git-mergetool.sh | 4 ++-- > git-rebase--interactive.sh | 2 +- > git-submodule.sh | 29 +++++++++++++++++------------ > t/t0025-crlf-auto.sh | 6 +++--- > t/t0026-eol-config.sh | 8 ++++---- > t/t4102-apply-rename.sh | 2 +- > t/t5000-tar-tree.sh | 2 +- > t/t5403-post-checkout-hook.sh | 8 ++++---- > t/t5537-fetch-shallow.sh | 2 +- > t/t5538-push-shallow.sh | 2 +- > t/t9814-git-p4-rename.sh | 4 ++-- > t/test-lib-functions.sh | 4 ++-- > 19 files changed, 49 insertions(+), 44 deletions(-) I still think one patch per file is too many patches for this. It would be easier to read with, e.g., whichever ones were most complex as separate patches and the rest (the "easy" ones) as a single patch. Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html