As a maintainer, I often get patches by mail, then acked-by,reviewed-by etc responses are sent by separate mail. I like making acks commits, this way they are easy to keep track of as part of git history. Since response mail happens to have appropriate subject matching the patch, it's a natural fit to then use git rebase mechanics if we want to smash these acks into the original commit. I have been using these patches without any problems for a while now, and find the approach very convenient. Included: rebase: new ack! action to handle ack commits this part seems ready for merge to me, please review and comment git-ack: new tool to record an ack this does not have proper documentation and tests yet, I definitely intend to do this but wanted to see whether people like the UI first. posting for early review and feedback Note: yes, I think notes+git replace could be used for this too, my workflow always includes a rebase with --autosquash before publishing anyway, so dealing with ack as with any other commit is nicer. Michael S. Tsirkin (4): rebase -i: add ack action git-rebase: document ack rebase: test ack git-ack: record an ack Documentation/git-rebase.txt | 45 ++++++++++++++++++++++--- contrib/git-ack | 79 ++++++++++++++++++++++++++++++++++++++++++++ git-rebase--interactive.sh | 34 +++++++++++++++---- t/t3415-rebase-autosquash.sh | 15 +++++++++ 4 files changed, 161 insertions(+), 12 deletions(-) create mode 100755 contrib/git-ack -- MST -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html