On Thu, May 15, 2014 at 07:42:00PM +0200, Johannes Schindelin wrote: > > Hrm. Is this patch still necessary? In the time since this patch was > > written, we did 0826579 (grep: load file data after checking > > binary-ness, 2012-02-02) > > I have no time to test this but I trust that you made sure that it works > as advertised. In my case, there were about 500 gigabytes of image data > intermixed with code, and waiting for 'git grep' was not funny at all (and > I did not have time back then to go through a full code submission cycle > on the Git mailing list, either). > > So I guess we can drop my patch. Certainly I tested it at the time (those commits I referenced contain timing information), and it should have improved the workload you describe. I did not test before/after the patch in this thread, but only read it and noticed that it was trying to do the same thing (that is why I said "I suspect..."). As the person who is proposing the patch for git.git, I would hope Stepan would follow up on such review and confirm whether or not it is still needed. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html