Jeff King <peff@xxxxxxxx> writes: > On Wed, May 14, 2014 at 05:44:19PM +0200, Stepan Kasal wrote: > >> From: Johannes Schindelin <johannes.schindelin@xxxxxx> >> Date: Mon, 8 Nov 2010 16:10:43 +0100 >> >> Incidentally, this makes grep -I respect the "binary" attribute (actually, >> the "-text" attribute, but "binary" implies that). >> >> Since the attributes are not thread-safe, we now need to switch off >> threading if -I was passed. >> >> Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx> >> Signed-off-by: Stepan Kasal <kasal@xxxxxx> >> --- >> >> Hi, >> this patch has been in msysgit for 3.5 years. >> Stepan > > Hrm. Is this patch still necessary? In the time since this patch was > written, we did 0826579 (grep: load file data after checking > binary-ness, 2012-02-02), which should do the same thing. It deals with > the threading via a lock, but we later learned in 9dd5245 (grep: > pre-load userdiff drivers when threaded, 2012-02-02) to hoist that bit > out. Wow, power of Git history ;-) > So I suspect this patch at best is doing nothing, and at worst is > wasting extra time doing redundant attribute checks. Sounds like a sensible conclusion. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html