On Sat, May 10, 2014 at 10:02:59AM -0400, Jeff King wrote: > On Fri, May 09, 2014 at 02:08:27PM -0700, Junio C Hamano wrote: > > > > 3. Just disable the http tests when run as root. > > > > > > I think I'd favor 3. But I'd like to be sure that being root is the > > > problem. > > > > I agree with both the conclusion and the precondition. > > Here's the patch. > > The problem starts in v1.9.2, not in v2.0.0, so it's not technically a > regression in this cycle. And we are awfully late in the -rc period. But > it is just a change in the test script, and one that seems rather > unlikely to produce unexpected side effects. I'll leave it you whether > you want to queue it for v2.0.0, or for the next maint release. Hrm, sorry, I was wrong about this. I had thought the auto-network-testing had gone into v1.9.2, but it didn't. So this _is_ a potential regression in v2.0.0. It's still relatively minor, affecting only the test suite, so it can probably wait for post-v2.0.0 if you don't want to do another -rc. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html