On Tue, May 13, 2014 at 11:29 PM, Per Cederqvist <cederp@xxxxxxxxx> wrote:
> On Tue, May 13, 2014 at 10:54 PM, Jeff Sipek <jeffpc@xxxxxxxxxxxxxx> wrote:
>> On Tue, May 13, 2014 at 04:45:47PM -0400, Theodore Ts'o wrote:
>>> On Tue, May 13, 2014 at 10:30:36PM +0200, Per Cederqvist wrote:
>> ...
>>> > - Changed behavior: by default, guilt no longer changes branch when
>>> > you push a patch. You need to do "git config guilt.reusebranch
>>> > false" to re-enable that. This patch sets the default value of
>>> > guilt.reusebranch to true; it should in my opinion change to false
>>> > a year or two after the next release.
>>>
>>> We've been living with the "origin" -> "guilt/origin" branch change
>>> for a year already, and in fact, these days I've gotten used to the
>>> new behavior. Is it really worth it to change the default?
>>
>> So, at first I was skeptical about the branch name prefix change. I've used
>> it for about a year now, and I love it. When I first read Per's idea to
>> change the default to the old-style, I was a bit sad but I understand the
>> motivation.
>>
>> I'm open to either mode being the default since it's easy enough for me to
>> change it for me (thanks, ~/.gitconfig) but I think more people should
>> benefit from the added safety against accidental git-push. (I also like
>> being able to use guilt/master..master to get only the commits I care
>> about.) Thoughts?
>
> I don't have a strong opinion on which the default value should be.
> The scenario where it matters, when you run multiple versions of
> guilt against the same directory, is probably very rare in practice.
> If it is mentioned in the release note that it can be changed if needed,
> that is probably good enough.
>
> /ceder
I will change the default value to false in the next version of the patch
series, unless there are objections. I plan to send it to the list Friday
morning.
/ceder
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html