On Wed, 14 Feb 2007, Junio C Hamano wrote: > Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes: > > > Actually, my patch already had one that you didn't mention: > > 6) CR never shows up alone. > > Older Macs ;-)? Yeah, I think we can ignore them.. Let's see if anybody ever complains ;) > I would agree. 0-31 except HT, CR, LF and ESC would be a good > idea; that would not harm text in UTF-8, EUC based various > locales nor ISO 2022. You could possibly add 127 to the list too (it's ascii DEL, I don't know if you should ever see it in anything that has anything to do with text). > - if (stats->nul) > + if (stats->nonprintable) But this is too harsh. It's quite common to have the occasional FF character. Some things really do use it for page breaks. So saying that *any* nonprintable character is bad is not a good idea. Same goes for BS (some programs use it to show bold and underlined text: man-pages, for example). Linus - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html