On Tue, May 13, 2014 at 1:34 AM, Erik Faye-Lund <kusmabite@xxxxxxxxx> wrote: > On Tue, May 13, 2014 at 8:01 AM, Stepan Kasal <kasal@xxxxxx> wrote: >> From: Pat Thoyts <patthoyts@xxxxxxxxxxxxxxxxxxxxx> >> Date: Wed, 24 Oct 2012 00:15:29 +0100 >> >> Signed-off-by: Pat Thoyts <patthoyts@xxxxxxxxxxxxxxxxxxxxx> >> Signed-off-by: Stepan Kasal <kasal@xxxxxx> >> --- >> contrib/credential/wincred/Makefile | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/contrib/credential/wincred/Makefile b/contrib/credential/wincred/Makefile >> index 39fa5e0..e64cd9a 100644 >> --- a/contrib/credential/wincred/Makefile >> +++ b/contrib/credential/wincred/Makefile >> @@ -1,9 +1,5 @@ >> all: git-credential-wincred.exe >> >> -CC = gcc >> -RM = rm -f >> -CFLAGS = -O2 -Wall >> - > > Would it be better to set these if not already set, i.e: > > -CC = gcc > -RM = rm -f > -CFLAGS = -O2 -Wall > +CC ?= gcc > +RM ?= rm -f > +CFLAGS ?= -O2 -Wall > > instead? Set by whom? If it's by the environment you should be running 'make -e'. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html