From: Pat Thoyts <patthoyts@xxxxxxxxxxxxxxxxxxxxx> Date: Wed, 24 Oct 2012 00:15:29 +0100 Signed-off-by: Pat Thoyts <patthoyts@xxxxxxxxxxxxxxxxxxxxx> Signed-off-by: Stepan Kasal <kasal@xxxxxx> --- Hi kusma, On Tue, May 13, 2014 at 08:34:36AM +0200, Erik Faye-Lund wrote: > Would it be better to set these if not already set, i.e: > > -CC = gcc > -RM = rm -f > -CFLAGS = -O2 -Wall > +CC ?= gcc > +RM ?= rm -f > +CFLAGS ?= -O2 -Wall > > instead? ... and moving it after the two includes, so that it does not override the values set there? Can you ack this? contrib/credential/wincred/Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contrib/credential/wincred/Makefile b/contrib/credential/wincred/Makefile index 39fa5e0..6e992c0 100644 --- a/contrib/credential/wincred/Makefile +++ b/contrib/credential/wincred/Makefile @@ -1,12 +1,12 @@ all: git-credential-wincred.exe -CC = gcc -RM = rm -f -CFLAGS = -O2 -Wall - -include ../../../config.mak.autogen -include ../../../config.mak +CC ?= gcc +RM ?= rm -f +CFLAGS ?= -O2 -Wall + prefix ?= /usr/local libexecdir ?= $(prefix)/libexec/git-core -- 1.9.2.msysgit.0.161.g83227c1 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html