Re: [PATCH v1 06/25] contrib: remove 'diffall'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 8, 2014 at 5:58 PM, Felipe Contreras
<felipe.contreras@xxxxxxxxx> wrote:
> No activity since 2010, no tests.
>
> Cc: Tim Henigan <tim.henigan@xxxxxxxxx>
> Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
> ---
>  contrib/diffall/README      |  31 ------
>  contrib/diffall/git-diffall | 257 --------------------------------------------
>  2 files changed, 288 deletions(-)
>  delete mode 100644 contrib/diffall/README
>  delete mode 100755 contrib/diffall/git-diffall

I see no problem with removing this script from contrib.  However, the
commit message
should mention that git-difftool learned all the features of
git-diffall when the '--dir-diff'
option was added in v1.7.11 (ca. June 2012).

Also, the script was first added to contrib in Feb. 2012, so "no
activity since 2010" is
incorrect.  I'm not sure this information is useful in the commit
message at all.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]