Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > Junio C Hamano wrote: >> Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: >> >> > Here's a bunch of tests more, and a fixes for Mercurial v3.0. >> >> I think the discussion with John Keeping hints that we shouldn't be >> rushing fc/remote-helpers-hg-bzr-graduation > > Really? Based on what reasoning? I have proven his reasoning to be > basically wrong. Perhaps s/proven/convinced myself only/; you didn't prove it to me and I doubt you proved it to John. >> For example, I see >> >> from mercurial import changegroup >> if check_version(3, 0): >> cg = changegroup.getbundle(...) >> else: >> cg = repo.getbundle(...) >> >> and offhand it was unclear if the unconditional import was a >> mistake. > > Of course it wasn't a mistake. I doubt about the "Of course" part. The first reaction after seeing that the new "changegroup" is used only inside check_version(3,0) and nowhere else was to wonder if that import is necessary (or even safe) for the pre-v3.0 versions. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html