On 6 May 2014 08:01, Jeff King <peff@xxxxxxxx> wrote: > [fixed David's address in cc list] Ah, right. Wasn't sure what was going on there. > On Tue, May 06, 2014 at 07:54:30AM +1000, James Denholm wrote: > >> Given that subtree subtree doesn't really generate a lot of discussion, >> would it be advisable to wrap this up (barring further discussion) and send >> it off to Junio rather than waiting for further community consensus? > > I do not know if "lack of discussion" is a good reason to consider > something in good shape; oftentimes it is a sign that nobody is > interested in the area. We usually rely on "area maintainers" to give an > OK to the patches if they are not something that the maintainer himself > has an interest in. Yeah, I certainly only meant that in the context of this particular patch, post-review. > However, in this case, you did get review, and I think it is pretty easy > to see the patches are good even if one does not care about the > particular area. So I think they are fine to pass on and apply. Sounds good, I'll send it on up now. Thanks again for the help. > Note also that patches like this are a great place to get started, as > they help build trust in a contributor, who can later help out with > area maintenance. Yeah, to be honest, beyond the immediate goal of getting subtree in more distros, that is kinda the plan. A bit of a practical experience in contributing to the project, learning the specific ropes and such before proposing more substantial discussion and fixes/changes. --- Regards, James Denholm. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html