Re: [PATCH] t3910: show failure of core.precomposeunicode with decomposed filenames

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 5, 2014 at 11:46 PM, Jeff King <peff@xxxxxxxx> wrote:
> On Sun, May 04, 2014 at 08:13:15AM +0200, Torsten Bögershausen wrote:
>
>> >   1. Tell everyone that NFD in the git repo is wrong, and
>> >      they should make a new commit to normalize all their
>> >      in-repo files to be precomposed.
>> >      This is probably not the right thing to do, because it
>> >      still doesn't fix checkouts of old history. And it
>> >      spreads the problem to people on byte-preserving
>> >      filesystems (like ext4), because now they have to start
>> >      precomposing their filenames as they are adde to git.
>>      (typo:                                                                  ^added)
>> I'm not sure if I follow. People running ext4 (or Linux in general,
>> or Windows, or Unix) do not suffer from file system
>> "feature" of Mac OS, which accepts precomposed/decomposed Unicode
>> but returns decompomsed.
>
> What I mean by "spreads the problem" is that git on Linux does not need
> to care about utf8 at all. It treats filenames as a byte sequence. But
> if we were to start enforcing "filenames should be precomposed utf8",
> then people adding files on Linux would want to enforce that, too.
>
> People on Linux could ignore the issue as they do now, but they would
> then create problems for OS X users if they add decomposed filenames.
> IOW, if the OS X code assumes "all repo filenames are precomposed", then
> other systems become a possible vector for violating that assumption.

FWIW, Git for Windows also doesn't deal with that "filenames are just
a byte-sequence"-notion. We have patches in place that require
filenames to *either* be valid UTF-8 or Windows-1252. Windows itself
treats filenames as Unicode characters, not arbitrary byte sequences.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]