On Tue, May 06, 2014 at 07:41:29AM +1000, James Denholm wrote: > >I do not think BSD-ism matters for "rm", as it works pretty much the > >same everywhere. "install", on the other hand, is a bit weirder between > >systems. So you might want to leave that comment as-is. > > True. I might just buff that out when sending the patch to Junio, unless > protocol dictates otherwise - a reroll for a single comment line seems > a bit excessive to me at the moment. I don't think it is that big a deal either way. It's fine to tweak when you send re-roll the final for Junio. Sometimes for trivial fixups like this, Junio can just tweak it as he applies, but I do not know if he is even paying attention to this thread, so you may want to re-post anyway to get his attention. Either way, feel free to add my: Reviewed-by: Jeff King <peff@xxxxxxxx> -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html