Dave Borowitz <dborowitz@xxxxxxxxxx> writes: > On Mon, Apr 28, 2014 at 1:05 PM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: >> Dave Borowitz wrote: >> >>> Instead, if CURL_CONFIG is empty or returns an empty result (e.g. due >>> to curl-config being missing), use the old behavior of falling back to >>> -lcurl. >>> --- >>> Makefile | 36 +++++++++++++++++++++++++----------- >>> 1 file changed, 25 insertions(+), 11 deletions(-) >> >> Sign-off? > > Oops. Will forge your sign-off while queuing ;-) > > How about: > "If CURL_CONFIG is unset or points to a binary that is not found, > defaults to the CURLDIR behavior. If CURLDIR is not set, this means > using -lcurl with no additional library detection (other than > NEEDS_*_WITH_CURL). ... with this rephrasing. >>> - $(error libcurl not detected; try setting CURLDIR) >>> + $(error libcurl not detected or not compiled with static support) >> >> Whitespace damage. > > Yes, but intentional, because Makefile parsing is weird. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html