On Mon, Apr 28, 2014 at 9:59 PM, Torsten Bögershausen <tboegi@xxxxxx> wrote: > On 2014-04-28 15.51, Marat Radchenko wrote: >> mingw-w64 has lseek defined in io.h. > [] >> #define off_t off64_t >> +#ifndef lseek >> #define lseek _lseeki64 >> +#endif > Is the commit message in line with the code? > > I would have expected something in this style: > > #if defined(__x86_64__) && ! defined(lseek)) > #include <io.h> > #endif No, we want 64-bit off_t either way, to support large files. So we need the version that takes a 64-bit argument. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html