On Mon, Apr 28, 2014 at 05:17:25PM +0200, Erik Faye-Lund wrote: > > 1. What are other ways to provide iconv on MinGW? > > I'm not sure I understand. To set HAVE_LIBCHARSET_H, we need to have > libcharset.h. MinGW doesn't supply by default to my knowledge, so we > get it from iconv. The THIS_IS_MSYSGIT file is there for us to be able > to pick the right defaults for msysGit, and us having libcharset is > indeed a msysGit-detail. Not all iconv-flavors supply libcharset.h, so > this tells a particularity about the one we have in msysGit. > > 2. One can still completely disable iconv with NO_ICONV=1 > > Sure. And it does seem like the current setup assumes that anyone > building for MinGW has iconv. But perhaps that's a mistake? This patch assumes that "if user has iconv under MinGW, he has libcharset.h". Without it, we assume "if user has iconv under MinGW, he has langinfo.h". If user doesn't have iconv, he needs to say this via NO_ICONV=1 in both cases. Anyway, if it is a questionable change, I'll drop it and only keep NO_R_TO_GCC_LINKER change. > To be honest, I think the whole THIS_IS_MSYSGIT-block should have > stayed downstream. That's a completely different story. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html