On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko <marat@xxxxxxxxxxxxxxxx> wrote:
> -D__USE_MINGW_ACCESS only affects MinGW and does nothing when
> MSVC is used.
Seems reasonable in itself.
But, doesn't this mean that our access are currently broken on MSVC?
The comment about __USE_MINGW_ACCESS is:
/* Old versions of MSVCRT access() just ignored X_OK, while the version
shipped with Vista, returns an error code. This will restore the
old behaviour */
This sounds like we should lift the access-fix up one abstraction, into Git.
But wait a minute. In Git for Windows, we already wrapped up access
for unicode-support (03a102ff - "Win32: Unicode file name support
(except dirent)"), doing the exact same thing already. This patch
isn't upstreamed yet, though.
Sounds like there's some cleaning up left to do on our behalf :)
This clean-up makes sense regardless, though.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html