On Mon, Apr 28, 2014 at 3:20 PM, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > Hi kusma, > > On Mon, 28 Apr 2014, Erik Faye-Lund wrote: > >> On Mon, Apr 28, 2014 at 10:48 AM, Erik Faye-Lund <kusmabite@xxxxxxxxx> wrote: >> > So it seems that 08900987 ("Decide whether to build http-push in the >> > Makefile") makes a bad assumption about the availability of >> > curl-config on new libcurl installations; it's not present on "stock" >> > Windows builds. >> >> I wonder, though. That check is over 8 years old. Are that old systems >> (that haven't been upgraded) still able to build Git? Even my old >> RedHat 5 setup has curl 7.15.5... > > The easiest way in my humble opinion would be to install a script like > this into /mingw/bin/: > > -- snip -- > #!/bin/sh > > case "$1" in > --vernum) > version="$(curl -V)" || exit > version="$(echo "${version%% (*)*}" | tr . \ )" > eval printf "%02d%02d%02d" ${version#curl } > ;; > --cflags) > ;; > --libs) > echo -lcurl > ;; > esac > -- snap -- > > That way, upstream Git does not have anything to change (and we avoid > discussing five versions of essentially the same patch :-P). Huh? I think I only really proposed one patch...? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html