Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > Matthieu Moy wrote: >> Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: >> >> > Commit 26cd160 (rebase -i: use a better reflog message) tried to produce >> > a better reflog message, however, it seems a statement was introduced by >> > mistake. >> > >> > 'comment_for_reflog start' basically overides the GIT_REFLOG_ACTION we >> > just set. > >> So, one needs to reset $GIT_REFLOG_ACTION to what it used to be if is it >> to be used later. However, it seems to me that the "comment_for_reflog >> start" is used only for this checkout command. If so, there's no need >> for the "comment_for_reflog start" before the if statement either. > > Exactly. But if this variable is only meant for this command, it should be > `VAR=VAL command`, that would make it clear without the need of a comment. I don't understand. Are you suggesting to replace the shell function "output" with an external command? If not, which command would you want to call here? -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html