Ramkumar Ramachandra wrote: > Felipe Contreras wrote: > > It's more efficient to check for the braces first. > > Why is it more efficient? So you can error out quickly in the case of > a malformed string? That's one reason. The other is that get_sha1_basic() calls upstream_mark() when we _already_ know there's a @{foo}. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html