Re: [PATCH 17/19] Portable alloca for Git

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Erik Faye-Lund <kusmabite@xxxxxxxxx> writes:

>> Subject: [PATCH] mingw: activate alloca
>>
>> Both MSVC and MINGW have alloca(3) definitions in malloc.h, so by moving
>> win32-compat alloca.h from compat/vcbuild/include/ to compat/win32/ ,
>> which is included by both MSVC and MINGW CFLAGS, we can make alloca()
>> work on both those Windows environments.
>>
>> In MINGW, malloc.h has explicit check for GNUC and if it is so, defines
>> alloca to __builtin_alloca, so it looks like we don't need to add any
>> code to here-shipped alloca.h to get optimum performance.
>>
>> Compile-tested on Windows in MSysGit.
>>
>> Signed-off-by: Kirill Smelkov <kirr@xxxxxxxxxx>
>
> Looks good to me!

Thanks; queued and pushed out on 'next'.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]