On 04/02/2014 07:19 PM, Junio C Hamano wrote: > Michael Haggerty <mhagger@xxxxxxxxxxxx> writes: > >> This reduces the amount of string editing gyrations and makes it >> unnecessary for callers to know how to derive the filename from the >> lock_filename. > > Hmph. > > Is it worth duplicating the whole thing? If you are planning to > break the invariant lock_filename === filename + LOCK_SUFFIX in > future changes in the series, it is understandable, though. That is indeed the plan, but I'm splitting that change into a future patch series because this one is getting big enough already dealing with correctness issues. Michael -- Michael Haggerty mhagger@xxxxxxxxxxxx http://softwareswirl.blogspot.com/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html