Patches summary: 1. Fix initial issue (incorrect cast causing crash on 64-bit MSVC) 2. Improve OPT_SET_PTR to prevent same errors in future 3. Purge OPT_SET_PTR away since nobody uses it *Optional* patch №3 is separated from №1 and №2 so that if someone someday decides to return OPT_SET_PTR back by reverting №3, it will be returned in a sane state. Decision of (not) merging №3 is left as an exercise to the reader due to my insufficient knowledge of accepted practices in Git project. Marat Radchenko (3): MSVC: fix t0040-parse-options crash parse-options: add cast to correct pointer type to OPT_SET_PTR parse-options: remove unused OPT_SET_PTR Documentation/technical/api-parse-options.txt | 4 ---- parse-options.c | 5 ----- parse-options.h | 5 +---- t/t0040-parse-options.sh | 7 +++---- test-parse-options.c | 2 -- 5 files changed, 4 insertions(+), 19 deletions(-) -- 1.9.0 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html