Marat Radchenko <marat@xxxxxxxxxxxxxxxx> writes: > Signed-off-by: Marat Radchenko <marat@xxxxxxxxxxxxxxxx> > --- > xdiff/xutils.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xdiff/xutils.c b/xdiff/xutils.c > index 62cb23d..a21a835 100644 > --- a/xdiff/xutils.c > +++ b/xdiff/xutils.c > @@ -23,6 +23,7 @@ > #include <limits.h> > #include <assert.h> > #include "xinclude.h" > +#include "git-compat-util.h" This is unfortunate for a few reasons: - xdiff/* is a borrowed code; we do not want to have (or add more) dependencies on the rest of Git, including compat-util. - When a piece of our code needs our compatibility support, compat-util must be the first header file included (either directly, or indirectly by including another header file that includes it at the top). My gut feeling is that adding a mechanism to add -DINLINE=__inline only on MSVC to the top-level Makefile, without touching this file, may be a much more palatable. I dunno. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html