Re: [PATCH 001/144] check-builtins.sh: use the $( ... ) construct for command substitution

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2014-03-25 9:35 GMT+01:00 Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx>:
> Elia Pinto <gitter.spiros@xxxxxxxxx> writes:
>
>> and is supported by POSIX. However,all but the simplest uses become
>
> Missing space after comma.
>
>> complicated quickly. In particular,embedded command substitutions
>
> Ditto.
>
> (neither should block merging, but they would be worth fixing if you
> need a reroll)
>
> Did you do these 144 patches by hand, or did you use a script (e.g. perl
> substitution or so) to do it? If the later, then you should include
> explanations in your commit message.

I had used a toy sed script. No bulletproof.  Then I did a manual review.

I review the patch series, adjust the comment was added, and resend the V2.

Thanks again
>
> --
> Matthieu Moy
> http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]