On Thu, Mar 20, 2014 at 8:40 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Wed, Mar 19, 2014 at 7:12 PM, Dragos Foianu <dragos.foianu@xxxxxxxxx> wrote: >> Eric Sunshine <sunshine <at> sunshineco.com> writes: >>> On Tue, Mar 18, 2014 at 6:31 PM, Eric Sunshine <sunshine <at> >> sunshineco.com> wrote: >>> >>> One other observation: You have a one-off error in your out-of-bounds >>> check. It should be 'index >= sizeof...' >> >> Well this is embarrassing. > > It's a good illustration of the value of the review process. It's easy > to overlook omissions and problems in our one's work because one reads > it with the bias of knowing what it's _supposed_ to say. Reviewers > (hopefully) don't have such bias: they read the code afresh. And, this is a perfect example. I knew that I wanted to say "problems in one's own work", and even though I proof-read, I still missed that I wrote "problems in our one's work". -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html