On Wed, Mar 19, 2014 at 10:28:46AM -0700, Junio C Hamano wrote: > [git config --file versus GIT_CONFIG=] > > Thanks. Then I think it makes sense to do such a conversion but it > probably should be done on top of this patch (we could do it before > this patch), not as a part of this patch. Here's a series that goes on top of what you queued in dt/tests-with-env-not-subshell. Once I started cleaning, I noticed a lot of room for improvement and modernization in t0001. I hope I didn't get too carried away. [01/12]: t/Makefile: stop setting GIT_CONFIG [02/12]: t/test-lib: drop redundant unset of GIT_CONFIG [03/12]: t: drop useless sane_unset GIT_* calls [04/12]: t: stop using GIT_CONFIG to cross repo boundaries [05/12]: t: prefer "git config --file" to GIT_CONFIG with test_must_fail [06/12]: t: prefer "git config --file" to GIT_CONFIG [07/12]: t0001: make symlink reinit test more careful [08/12]: t0001: use test_path_is_* [09/12]: t0001: use test_config_global [10/12]: t0001: use test_must_fail [11/12]: t0001: drop useless subshells [12/12]: t0001: drop subshells just for "cd" t/Makefile | 4 +- t/t0001-init.sh | 211 ++++++++++------------------------- t/t1300-repo-config.sh | 28 ++--- t/t1302-repo-version.sh | 2 +- t/t5701-clone-local.sh | 6 +- t/t7400-submodule-basic.sh | 5 +- t/t9130-git-svn-authors-file.sh | 3 +- t/t9154-git-svn-fancy-glob.sh | 6 +- t/t9400-git-cvsserver-server.sh | 1 - t/test-lib.sh | 1 - 10 files changed, 87 insertions(+), 180 deletions(-) -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html