Re: [PATCH v4 1/2] diff-no-index.c: rename read_directory()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrei Dinu <mandrei.dinu@xxxxxxxxx> writes:

> Signed-off-by: Andrei Dinu <mandrei.dinu@xxxxxxxxx>

The commit message should explain why this is a good change. In general,
the "why?" question is more important than the "what" (the reader can
see from the patch that you renamed the function, but cannot guess why
you did so).

Also, when sending multiple patches, send them as a single thread. See
for example:

  http://thread.gmane.org/gmane.comp.version-control.git/244441

In practice, call "git send-email" once, not once per patch. Try sending
the patches to yourself first to avoid disturbing the list in case of
user error.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]