On Tue, Mar 18, 2014 at 11:58 PM, Brian Bourn <ba.bourn@xxxxxxxxx> wrote:
> On Tue, Mar 18, 2014 at 11:45 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
> wrote:
>> On Tue, Mar 18, 2014 at 9:30 PM, babourn <ba.bourn@xxxxxxxxx> wrote:
>> > Subject: diff: used is_dot_or_dotdot() in code
>> > Signed-off-by: Brian Bourn <bab2177@xxxxxxxxxxxx>
>> > ---
>> > diff-no-index.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/diff-no-index.c b/diff-no-index.c
>> > index ba915af..44cce25 100644
>> > --- a/diff-no-index.c
>> > +++ b/diff-no-index.c
>> > @@ -26,7 +26,7 @@ static int read_directory_contents(const char *path,
>> > struct string_list *list)
>> > return error("Could not open directory %s", path);
>> >
>> > while ((e = readdir(dir)))
>> > - if (strcmp(".", e->d_name) && strcmp("..", e->d_name))
>> > + if (!is_dot_or_dotdot(e->d_name))
>>
>> The patch is severely whitespace-damaged. (Did you post it through
>> Nabble?)
>
> I did post through Nabble, My email with the patch didn't seem to be
> going through.
> should I keep trying to resend it through email to undo the whitspace
> damage?
It's probably not necessary to try resending this version of the patch
since you'll (hopefully) be sending a newer version which takes
reviewer comments into consideration.
What method are you using to send the patches? git send-email?
Something other? This particular mailing list rejects HTML-formatted
messages, so that could be the culprit if you pasted the patch into
your email client. It's a good idea to try sending patches to yourself
via "git send-email". If you can get that to work successfully, then
they should be accepted by the mailing list when sent via the same
mechanism.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html