On Fri, Mar 14, 2014 at 05:09:45PM -0700, Shawn Pearce wrote: > On Fri, Mar 14, 2014 at 4:30 PM, Duy Nguyen <pclouds@xxxxxxxxx> wrote: > > On Fri, Mar 14, 2014 at 11:45 PM, Shawn Pearce <spearce@xxxxxxxxxxx> wrote: > >> > >> You missed the SSH case. It doesn't have this slot to hide the data into. > > > > Right now we run this for ssh case: "ssh <host> git-upload-pack > > <repo-path>". New client can do this instead > > > > ssh <host> git-upload-pack <repo-path> <client capability flags> > > Older servers will fail on this command, and the client must reconnect > over SSH, which may mean supplying their password/passphrase again. > But its remembered that the uploadPack2 didn't work so this can be > blacklisted and not retried for a while. I wonder if we could use the environment for optional values. E.g., can we run: ssh host GIT_CAPABILITIES=... git-upload-pack <repo-path> That will not work everywhere, of course. Sites with git-shell will fail, as will sites with custom ssh handler (GitHub, for example, and I imagine Gerrit sites, if they support ssh). So we'd still need some fallback, but it would work out-of-the-box in a reasonable number of cases (and it is really not that different than the http case, which is just stuffing the values into $QUERY_STRING anyway :) ). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html