David Kastrup <dak@xxxxxxx> writes: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> Taking two random examples from an early and a late parts of the >> patch: >> >> --- a/builtin/cat-file.c >> +++ b/builtin/cat-file.c >> @@ -82,7 +82,7 @@ static int cat_one_file(int opt, const char *exp_type, const char *obj_name) >> enum object_type type; >> unsigned long size; >> char *buffer = read_sha1_file(sha1, &type, &size); >> - if (memcmp(buffer, "object ", 7) || >> + if (!starts_with(buffer, "object ") || > > [...] > >> The original hunks show that the code knows and relies on magic >> numbers 7 and 8 very clearly and there are rooms for improvement. > > Like: what if the file is empty? Yes. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html