Jeff King <peff@xxxxxxxx> writes: > Most of us who compile with -Wall decided a while ago to use > -Wno-format-zero-length, because it really is a silly complaint (it > assumes there are no side effects of the function besides printing the > format string, which is obviously not true in this case). > > It would be nice to compile out of the box with "-Wall -Werror", and I > think your solution looks relatively clean. But I am slightly concerned > about the assumption that it is OK to pass a NULL fmt parameter to a > function marked with __attribute__((format)). It certainly seems to be > the case now, and I do not know of any plans for that to change, but it > seems like a potentially obvious thing for the compiler to check. Yes, exactly. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html